Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brief voice instructions #1435

Merged
merged 2 commits into from
May 28, 2023
Merged

Brief voice instructions #1435

merged 2 commits into from
May 28, 2023

Conversation

Karry
Copy link
Collaborator

@Karry Karry commented May 21, 2023 •
edited
Loading

Navigation voice instructions are too verbose in some situations.

  • skip short (<50 meters) distance information when vehicle is car
  • use short roundabout instruction when roundabout is close

@Karry Karry temporarily deployed to SONAR May 21, 2023 20:59 — with GitHub Actions Inactive
@Framstag Framstag added feature For issues and pull request that request or implement a new feature routing For routing issues labels May 22, 2023
@Karry Karry force-pushed the brief-voice-instructions branch from 2b259f6 to f8f36e1 Compare May 26, 2023 22:09
@Karry Karry temporarily deployed to SONAR May 26, 2023 22:09 — with GitHub Actions Inactive
@Karry Karry temporarily deployed to SONAR May 26, 2023 23:22 — with GitHub Actions Inactive
@Karry
move roundabout voice message to roundabout enter
b69c13b 
And use short roundabout instruction when roundabout is close.
Instead of phrase "on the roundabout, use the third exit"
use just "use the third exit".
@Karry Karry force-pushed the brief-voice-instructions branch from a5dc986 to b69c13b Compare May 27, 2023 07:32
@Karry Karry temporarily deployed to SONAR May 27, 2023 07:33 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Karry Karry marked this pull request as ready for review May 27, 2023 22:15
@Framstag Framstag merged commit 7bed716 into Framstag:master May 28, 2023
17 of 18 checks passed
@Karry Karry deleted the brief-voice-instructions branch May 28, 2023 19:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

🎉 This issue has been resolved in v2024.06.02.1 (Release Notes)

@github-actions github-actions bot added the released Issue has been released label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature For issues and pull request that request or implement a new feature released Issue has been released routing For routing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Karry @Framstag